Arnold metadata : Show color_jitter.data_input in Graph Editor
#5936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnold doesn't seem to be entirely consistent about whether it declares the `linkable` metadata for all parameters or not, and it wasn't declaring it in this case despite the parameter being linkable in practice. That meant that ArnoldShaderUI fell through to a heuristic that assumes that ints aren't linkable and so don't need to be shown in the GraphEditor. We now declare the `linkable` metadata ourselves, and for good measure, also make `data_input` visible by default rather than hidden behind the `+` button.
murraystevenson
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arnold doesn't seem to be entirely consistent about whether it declares the
linkablemetadata for all parameters or not, and it wasn't declaring it in this case despite the parameter being linkable in practice. That meant that ArnoldShaderUI fell through to a heuristic that assumes that ints aren't linkable and so don't need to be shown in the GraphEditor. We now declare thelinkablemetadata ourselves, and for good measure, also makedata_inputvisible by default rather than hidden behind the+button.